fix: resolve all failing tests and type errors across monorepo#1
Open
stooit wants to merge 1 commit into
Open
Conversation
- Rename useThrottle → useDebounce import in apps/web/src/lib/api.ts and export useSearchDebounce alias to match test expectations - Fix Button component to use useCallback for stable onClick reference (stale closure bug caught by re-render test) - Add aria-label to DataTable component as required by accessibility test - Fix date formatting utility to use correct locale/format string - Configure bun test environment (happy-dom) for UI package tests - Add bun-types to tsconfig to resolve bun:test type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 13 failing tests and eliminates all TypeScript type errors in this multi-package monorepo.
Changes
packages/utils/src/format/date.tspackages/utils/src/hooks/→apps/web/src/lib/api.tsuseThrottletouseDebounce(hook was renamed in utils but consumers still referenced the old name)useSearchDebouncere-export alias expected by the web app's test suitepackages/ui/src/components/Button/Button.tsxpackages/ui/src/components/DataTable/DataTable.tsxaria-labelaccessibility attribute expected by the DataTable testConfiguration
happy-domtest environment inbunfig.tomlfor UI package tests (document is not defined)bun-typestotsconfig.jsonto resolvebun:testtype declarationsVerification
Assumptions
bun:testtype resolution was fixed via tsconfig rather than adding a new dependencyhappy-domwas already available in node_modules (no new dependency added)